Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a03ab788 authored by Coly Li's avatar Coly Li Committed by Joel Becker
Browse files

ocfs2: one more warning fix in ocfs2_file_aio_write(), v2 



This patch fixes another compiling warning in ocfs2_file_aio_write() like this,
    fs/ocfs2/file.c: In function ‘ocfs2_file_aio_write’:
    fs/ocfs2/file.c:2026: warning: suggest parentheses around ‘&&’ within ‘||’

As Joel suggested, '!ret' is unary, this version removes the wrap from '!ret'.

Signed-off-by: default avatarColy Li <coly.li@suse.de>
Signed-off-by: default avatarJoel Becker <joel.becker@oracle.com>
parent efd647f7

fs/ocfs2/file.c

+3 −3
Original line number Diff line number Diff line
@@ -2021,8 +2021,8 @@ static ssize_t ocfs2_file_aio_write(struct kiocb *iocb, 
		if (ret < 0)

			written = ret;



		if (!ret && (old_size != i_size_read(inode) ||

		    old_clusters != OCFS2_I(inode)->ip_clusters ||

		if (!ret && ((old_size != i_size_read(inode)) ||

			     (old_clusters != OCFS2_I(inode)->ip_clusters) ||

			     has_refcount)) {

			ret = jbd2_journal_force_commit(osb->journal->j_journal);

			if (ret < 0)