Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9fef8478 authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller
Browse files

cxgb4: potential shift wrapping bug 



"cntxt_id" is an unsigned int but "udb" is a u64 so there is a potential
shift wrapping bug here.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 4567dc10

drivers/net/ethernet/chelsio/cxgb4/sge.c

+1 −1
Original line number Diff line number Diff line
@@ -2258,7 +2258,7 @@ static u64 udb_address(struct adapter *adap, unsigned int cntxt_id, 
		(QUEUESPERPAGEPF1 - QUEUESPERPAGEPF0) * adap->fn);

	udb_density = 1 << ((qpp >> s_qpp) & QUEUESPERPAGEPF0_MASK);

	qpshift = PAGE_SHIFT - ilog2(udb_density);

	udb = cntxt_id << qpshift;

	udb = (u64)cntxt_id << qpshift;

	udb &= PAGE_MASK;

	page = udb / PAGE_SIZE;

	udb += (cntxt_id - (page * udb_density)) * SGE_UDB_SIZE;