Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9fc59306 authored by Achiad Shochat's avatar Achiad Shochat Committed by David S. Miller
Browse files

net/mlx5e: Avoid redundant dev_kfree_skb() upon NOP completion 



NOP completion SKBs are always NULL.

Signed-off-by: default avatarAchiad Shochat <achiad@mellanox.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@mellanox.com>
Signed-off-by: default avatarOr Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ef583d03

drivers/net/ethernet/mellanox/mlx5/core/en_tx.c

+1 −3
Original line number Diff line number Diff line
@@ -294,7 +294,7 @@ bool mlx5e_poll_tx_cq(struct mlx5e_cq *cq) 
		if (unlikely(!skb)) { /* nop */

			sq->stats.nop++;

			sqcc++;

			goto free_skb;

			continue;

		}



		for (j = 0; j < MLX5E_TX_SKB_CB(skb)->num_dma; j++) {
@@ -309,8 +309,6 @@ bool mlx5e_poll_tx_cq(struct mlx5e_cq *cq) 
		npkts++;

		nbytes += MLX5E_TX_SKB_CB(skb)->num_bytes;

		sqcc += MLX5E_TX_SKB_CB(skb)->num_wqebbs;



free_skb:

		dev_kfree_skb(skb);

	}