Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9f3e9bbe authored by Roel Kluin's avatar Roel Kluin Committed by Eric Van Hensbergen
Browse files

unsigned fid->fid cannot be negative 



Signed-off-by: default avatarRoel Kluin <roel.kluin@gmail.com>
Signed-off-by: default avatarEric Van Hensbergen <ericvh@gmail.com>
parent 1558c621

net/9p/client.c

+5 −4
Original line number Diff line number Diff line
@@ -608,7 +608,7 @@ p9_client_rpc(struct p9_client *c, int8_t type, const char *fmt, ...) 


static struct p9_fid *p9_fid_create(struct p9_client *clnt)

{

	int err;

	int ret;

	struct p9_fid *fid;

	unsigned long flags;
@@ -617,11 +617,12 @@ static struct p9_fid *p9_fid_create(struct p9_client *clnt) 
	if (!fid)

		return ERR_PTR(-ENOMEM);



	fid->fid = p9_idpool_get(clnt->fidpool);

	ret = p9_idpool_get(clnt->fidpool);

	if (fid->fid < 0) {

		err = -ENOSPC;

		ret = -ENOSPC;

		goto error;

	}

	fid->fid = ret;



	memset(&fid->qid, 0, sizeof(struct p9_qid));

	fid->mode = -1;
@@ -638,7 +639,7 @@ static struct p9_fid *p9_fid_create(struct p9_client *clnt) 


error:

	kfree(fid);

	return ERR_PTR(err);

	return ERR_PTR(ret);

}



static void p9_fid_destroy(struct p9_fid *fid)