Commit 9f322ad0 authored Jun 11, 2009 by Daniel Glöckner Committed by Linus Torvalds Jun 11, 2009

imx: serial: handle initialisation failure correctly



correctly de-initialise device when setting up failed,
call to pdata->exit() was missing.

Signed-off-by: Daniel Glöckner <dg@emlix.com>
Signed-off-by: Oskar Schirmer <os@emlix.com>
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 2e146392

drivers/serial/imx.c

+6 −1

Original line number	Diff line number	Diff line
		@@ -1157,10 +1157,15 @@ static int serial_imx_probe(struct platform_device *pdev)
		goto clkput;
		}

		uart_add_one_port(&imx_reg, &sport->port);
		ret = uart_add_one_port(&imx_reg, &sport->port);
		if (ret)
		goto deinit;
		platform_set_drvdata(pdev, &sport->port);

		return 0;
		deinit:
		if (pdata->exit)
		pdata->exit(pdev);
		clkput:
		clk_put(sport->clk);
		clk_disable(sport->clk);