Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9f1b3ebb authored by Laurent Pinchart's avatar Laurent Pinchart
Browse files

mx3fb: use display information in info not in var for panning 



We must not use any information in the passed var besides xoffset,
yoffset and vmode as otherwise applications might abuse it. Also use the
aligned fix.line_length and not the (possible) unaligned xres_virtual.

Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Tested-by: default avatarGuennadi Liakhovetski <g.liakhovetski@gmx.de>
parent 23dc8b1c

drivers/video/mx3fb.c

+3 −3
Original line number Diff line number Diff line
@@ -1062,15 +1062,15 @@ static int mx3fb_pan_display(struct fb_var_screeninfo *var, 
	y_bottom = var->yoffset;



	if (!(var->vmode & FB_VMODE_YWRAP))

		y_bottom += var->yres;

		y_bottom += fbi->var.yres;



	if (y_bottom > fbi->var.yres_virtual)

		return -EINVAL;



	mutex_lock(&mx3_fbi->mutex);



	offset = (var->yoffset * var->xres_virtual + var->xoffset) *

		(var->bits_per_pixel / 8);

	offset = var->yoffset * fbi->fix.line_length

	       + var->xoffset * (fbi->var.bits_per_pixel / 8);

	base = fbi->fix.smem_start + offset;



	dev_dbg(fbi->device, "Updating SDC BG buf %d address=0x%08lX\n",