Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9f0df936 authored by Colin Ian King's avatar Colin Ian King Committed by Vinod Koul
Browse files

dmaengine: coh901318: fix integer overflow when shifting more than 32 places 



Currently U300_DMA_CHANNELS is set to 40, meaning that the shift of 1 can
be more than 32 places, which leads to a 32 bit integer overflow. Fix this
by using 1ULL instead of 1 before shifting it.  Also add braces on the
for-loop to keep with coding style conventions.

Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarVinod Koul <vinod.koul@intel.com>
parent 2cc40ee7

drivers/dma/coh901318.c

+3 −2
Original line number Diff line number Diff line
@@ -1352,9 +1352,10 @@ static int coh901318_debugfs_read(struct file *file, char __user *buf, 


	tmp += sprintf(tmp, "DMA -- enabled dma channels\n");



	for (i = 0; i < U300_DMA_CHANNELS; i++)

		if (started_channels & (1 << i))

	for (i = 0; i < U300_DMA_CHANNELS; i++) {

		if (started_channels & (1ULL << i))

			tmp += sprintf(tmp, "channel %d\n", i);

	}



	tmp += sprintf(tmp, "Pool alloc nbr %d\n", pool_count);