Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9e8ab74d authored by Frederic Weisbecker's avatar Frederic Weisbecker Committed by Thomas Gleixner
Browse files

nvram: Drop the bkl from non-generic nvram_llseek() 



Drop the bkl from nvram_llseek() as it obviously protects nothing.
The file offset is safe in essence.

Signed-off-by: default avatarFrederic Weisbecker <fweisbec@gmail.com>
LKML-Reference: <1255116426-7270-1-git-send-email-fweisbec@gmail.com>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
parent 6783b9cd

drivers/char/nvram.c

+1 −3
Original line number Diff line number Diff line
@@ -38,7 +38,6 @@ 
#define NVRAM_VERSION	"1.3"



#include <linux/module.h>

#include <linux/smp_lock.h>

#include <linux/nvram.h>



#define PC		1
@@ -214,7 +213,6 @@ void nvram_set_checksum(void) 


static loff_t nvram_llseek(struct file *file, loff_t offset, int origin)

{

	lock_kernel();

	switch (origin) {

	case 0:

		/* nothing to do */
@@ -226,7 +224,7 @@ static loff_t nvram_llseek(struct file *file, loff_t offset, int origin) 
		offset += NVRAM_BYTES;

		break;

	}

	unlock_kernel();



	return (offset >= 0) ? (file->f_pos = offset) : -EINVAL;

}