Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9df04e9d authored by Laurent Pinchart's avatar Laurent Pinchart Committed by Mauro Carvalho Chehab
Browse files

[media] v4l: vsp1: Release buffers at stream stop 



videobuf2 expects no buffer to be owned by the driver when the
stop_stream queue operation returns. As the vsp1 driver fails to do so,
a warning is generated at stream top time.

Fix this by releasing all buffers queued on the IRQ queue in the
stop_stream operation handler and marking them as erroneous.

Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
parent aaa48cbb

drivers/media/platform/vsp1/vsp1_video.c

+3 −0
Original line number Diff line number Diff line
@@ -742,6 +742,7 @@ static void vsp1_video_stop_streaming(struct vb2_queue *vq) 
{

	struct vsp1_video *video = vb2_get_drv_priv(vq);

	struct vsp1_pipeline *pipe = to_vsp1_pipeline(&video->video.entity);

	struct vsp1_video_buffer *buffer;

	unsigned long flags;

	int ret;
@@ -759,6 +760,8 @@ static void vsp1_video_stop_streaming(struct vb2_queue *vq) 


	/* Remove all buffers from the IRQ queue. */

	spin_lock_irqsave(&video->irqlock, flags);

	list_for_each_entry(buffer, &video->irqqueue, queue)

		vb2_buffer_done(&buffer->buf, VB2_BUF_STATE_ERROR);

	INIT_LIST_HEAD(&video->irqqueue);

	spin_unlock_irqrestore(&video->irqlock, flags);

}