Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9d5d93e3 authored by Dan Carpenter's avatar Dan Carpenter Committed by James Bottomley
Browse files

[SCSI] megaraid: cleanup type issue in mega_build_cmd() 



On 64 bit systems the current code sets 32 bits of "seg" and leaves the
other 32 uninitialized.  It doesn't matter since the variable is never
used.  But it's still messy and we should fix it.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarAdam Radford <aradford@gmail.com>
Signed-off-by: default avatarJames Bottomley <JBottomley@Parallels.com>
parent a5254dbb

drivers/scsi/megaraid.c

+2 −2
Original line number Diff line number Diff line
@@ -524,7 +524,7 @@ mega_build_cmd(adapter_t *adapter, Scsi_Cmnd *cmd, int *busy) 
	mega_passthru	*pthru;

	scb_t	*scb;

	mbox_t	*mbox;

	long	seg;

	u32	seg;

	char	islogical;

	int	max_ldrv_num;

	int	channel = 0;
@@ -858,7 +858,7 @@ mega_build_cmd(adapter_t *adapter, Scsi_Cmnd *cmd, int *busy) 


			/* Calculate Scatter-Gather info */

			mbox->m_out.numsgelements = mega_build_sglist(adapter, scb,

					(u32 *)&mbox->m_out.xferaddr, (u32 *)&seg);

					(u32 *)&mbox->m_out.xferaddr, &seg);



			return scb;