Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9cfdc7aa authored by Boaz Harrosh's avatar Boaz Harrosh
Browse files

exofs: refactor exofs_i_info initialization into common helper 



There are two places that initialize inodes: exofs_iget() and
exofs_new_inode()

As more members of exofs_i_info that need initialization are
added this code will grow. (soon)

Signed-off-by: default avatarBoaz Harrosh <bharrosh@panasas.com>
parent fe33cc1e

fs/exofs/inode.c

+8 −2
Original line number Diff line number Diff line
@@ -908,6 +908,12 @@ static int exofs_get_inode(struct super_block *sb, struct exofs_i_info *oi, 
	return ret;

}





static void __oi_init(struct exofs_i_info *oi)

{

	init_waitqueue_head(&oi->i_wq);

	oi->i_flags = 0;

}

/*

 * Fill in an inode read from the OSD and set it up for use

 */
@@ -925,13 +931,13 @@ struct inode *exofs_iget(struct super_block *sb, unsigned long ino) 
	if (!(inode->i_state & I_NEW))

		return inode;

	oi = exofs_i(inode);

	__oi_init(oi);



	/* read the inode from the osd */

	ret = exofs_get_inode(sb, oi, &fcb, &sanity);

	if (ret)

		goto bad_inode;



	init_waitqueue_head(&oi->i_wq);

	set_obj_created(oi);



	/* copy stuff from on-disk struct to in-memory struct */
@@ -1062,8 +1068,8 @@ struct inode *exofs_new_inode(struct inode *dir, int mode) 
		return ERR_PTR(-ENOMEM);



	oi = exofs_i(inode);

	__oi_init(oi);



	init_waitqueue_head(&oi->i_wq);

	set_obj_2bcreated(oi);



	sbi = sb->s_fs_info;