Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9cccde93 authored by Rajashekhara, Mahesh's avatar Rajashekhara, Mahesh Committed by James Bottomley
Browse files

[SCSI] aacraid: add an ifdef'd device delete case instead of taking the device offline 



Problem description:
--------------------

The problem reported by one of the customer was when a logical array
is deleted(from the SDK, from the GUI, from arcconf) then the
corresponding physical device (/dev/sdb, for example) is not removed
from the Linux namespace. So you end up with a "dead" device
entry. And some of the linux tools go slightly wonky.

Solution:
---------

Based on the notification from FW, the driver calls
"scsi_remove_device" for the DELETED drive. This call not only informs
the scsi device status to the SCSI mid layer and also it will remove
corresponding scsi device entries from the Linux sysfs.

Signed-off-by: default avatarMahesh Rajashekhara <aacraid@adaptec.com>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@suse.de>
parent da3cc679

drivers/scsi/aacraid/aacraid.h

+3 −1
Original line number Diff line number Diff line
@@ -12,7 +12,7 @@ 
 *----------------------------------------------------------------------------*/



#ifndef AAC_DRIVER_BUILD

# define AAC_DRIVER_BUILD 26000

# define AAC_DRIVER_BUILD 26400

# define AAC_DRIVER_BRANCH "-ms"

#endif

#define MAXIMUM_NUM_CONTAINERS	32
@@ -26,6 +26,8 @@ 
#define AAC_MAX_HOSTPHYSMEMPAGES (0xfffff)

#define AAC_MAX_32BIT_SGBCOUNT	((unsigned short)256)



#define AAC_DEBUG_INSTRUMENT_AIF_DELETE



/*

 * These macros convert from physical channels to virtual channels

 */

drivers/scsi/aacraid/commsup.c

+8 −0
Original line number Diff line number Diff line
@@ -1133,6 +1133,9 @@ static void aac_handle_aif(struct aac_dev * dev, struct fib * fibptr) 
	if (device) {

		switch (device_config_needed) {

		case DELETE:

#if (defined(AAC_DEBUG_INSTRUMENT_AIF_DELETE))

			scsi_remove_device(device);

#else

			if (scsi_device_online(device)) {

				scsi_device_set_state(device, SDEV_OFFLINE);

				sdev_printk(KERN_INFO, device,
@@ -1141,6 +1144,7 @@ static void aac_handle_aif(struct aac_dev * dev, struct fib * fibptr) 
						"array deleted" :

						"enclosure services event");

			}

#endif

			break;

		case ADD:

			if (!scsi_device_online(device)) {
@@ -1155,12 +1159,16 @@ static void aac_handle_aif(struct aac_dev * dev, struct fib * fibptr) 
		case CHANGE:

			if ((channel == CONTAINER_CHANNEL)

			 && (!dev->fsa_dev[container].valid)) {

#if (defined(AAC_DEBUG_INSTRUMENT_AIF_DELETE))

				scsi_remove_device(device);

#else

				if (!scsi_device_online(device))

					break;

				scsi_device_set_state(device, SDEV_OFFLINE);

				sdev_printk(KERN_INFO, device,

					"Device offlined - %s\n",

					"array failed");

#endif

				break;

			}

			scsi_rescan_device(&device->sdev_gendev);