Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9c5ae691 authored by Janusz Dziedzic's avatar Janusz Dziedzic Committed by Kalle Valo
Browse files

ath10k: check allocation errors in CE 



Handle pci_alloc_consistent(), kmalloc()
errors in copy engine module.
Found during code review.

Signed-off-by: default avatarJanusz Dziedzic <janusz.dziedzic@tieto.com>
Signed-off-by: default avatarKalle Valo <kvalo@qca.qualcomm.com>
parent 4e72b232

drivers/net/wireless/ath/ath10k/ce.c

+22 −0
Original line number Diff line number Diff line
@@ -941,6 +941,12 @@ static int ath10k_ce_init_src_ring(struct ath10k *ar, 
				     (nentries * sizeof(struct ce_desc) +

				      CE_DESC_RING_ALIGN),

				     &base_addr);

	if (!src_ring->base_addr_owner_space_unaligned) {

		kfree(ce_state->src_ring);

		ce_state->src_ring = NULL;

		return -ENOMEM;

	}



	src_ring->base_addr_ce_space_unaligned = base_addr;



	src_ring->base_addr_owner_space = PTR_ALIGN(
@@ -957,6 +963,16 @@ static int ath10k_ce_init_src_ring(struct ath10k *ar, 
	src_ring->shadow_base_unaligned =

		kmalloc((nentries * sizeof(struct ce_desc) +

			 CE_DESC_RING_ALIGN), GFP_KERNEL);

	if (!src_ring->shadow_base_unaligned) {

		pci_free_consistent(ar_pci->pdev,

				    (nentries * sizeof(struct ce_desc) +

				     CE_DESC_RING_ALIGN),

				    src_ring->base_addr_owner_space,

				    src_ring->base_addr_ce_space);

		kfree(ce_state->src_ring);

		ce_state->src_ring = NULL;

		return -ENOMEM;

	}



	src_ring->shadow_base = PTR_ALIGN(

			src_ring->shadow_base_unaligned,
@@ -1026,6 +1042,12 @@ static int ath10k_ce_init_dest_ring(struct ath10k *ar, 
				     (nentries * sizeof(struct ce_desc) +

				      CE_DESC_RING_ALIGN),

				     &base_addr);

	if (!dest_ring->base_addr_owner_space_unaligned) {

		kfree(ce_state->dest_ring);

		ce_state->dest_ring = NULL;

		return -ENOMEM;

	}



	dest_ring->base_addr_ce_space_unaligned = base_addr;



	/*