Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9b73a584 authored by Dmitry Torokhov's avatar Dmitry Torokhov Committed by Rusty Russell
Browse files

module: do not hide __modver_version_show declaration behind ifdef 



Doing so prevents the following warning from sparse:

  CHECK   kernel/params.c
kernel/params.c:817:9: warning: symbol '__modver_version_show' was not
declared. Should it be static?

since kernel/params.c is never compiled with MODULE being set.

Signed-off-by: default avatarDmitry Torokhov <dtor@vmware.com>
Signed-off-by: default avatarRusty Russell <rusty@rustcorp.com.au>
parent b4bc8428

include/linux/module.h

+3 −2
Original line number Diff line number Diff line
@@ -64,6 +64,9 @@ struct module_version_attribute { 
	const char *version;

} __attribute__ ((__aligned__(sizeof(void *))));



extern ssize_t __modver_version_show(struct module_attribute *,

				     struct module *, char *);



struct module_kobject

{

	struct kobject kobj;
@@ -172,8 +175,6 @@ extern struct module __this_module; 
#define MODULE_VERSION(_version) MODULE_INFO(version, _version)

#else

#define MODULE_VERSION(_version)					\

	extern ssize_t __modver_version_show(struct module_attribute *,	\

					     struct module *, char *);	\

	static struct module_version_attribute ___modver_attr = {	\

		.mattr	= {						\

			.attr	= {					\