Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9b41b92b authored by Allen Hung's avatar Allen Hung Committed by Jean Delvare
Browse files

dmi-id: don't free dev structure after calling device_register 



dmi_dev is freed in error exit code but, according to the document
of device_register, it should never directly free device structure
after calling this function, even if it returned an error! Use
put_device() instead.

Signed-off-by: default avatarAllen Hung <allen_hung@dell.com>
Signed-off-by: default avatarJean Delvare <jdelvare@suse.de>
parent d71f0586

drivers/firmware/dmi-id.c

+4 −4
Original line number Diff line number Diff line
@@ -229,14 +229,14 @@ static int __init dmi_id_init(void) 


	ret = device_register(dmi_dev);

	if (ret)

		goto fail_free_dmi_dev;

		goto fail_put_dmi_dev;



	return 0;



fail_free_dmi_dev:

	kfree(dmi_dev);

fail_class_unregister:

fail_put_dmi_dev:

	put_device(dmi_dev);



fail_class_unregister:

	class_unregister(&dmi_class);



	return ret;