Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9b0f2582 authored by Alan Cox's avatar Alan Cox Committed by Greg Kroah-Hartman
Browse files

USB: ftdi_sio: Note missing locking 



The ftdi_sio driver has no internal locking on the dtr/rts state. Flag
that up for someone to fix.

Signed-off-by: default avatarAlan Cox <alan@redhat.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 2097890c

drivers/usb/serial/ftdi_sio.c

+2 −2
Original line number Diff line number Diff line
@@ -533,9 +533,8 @@ static int update_mctrl(struct usb_serial_port *port, unsigned int set, unsigned 
	}



	buf = kmalloc(1, GFP_NOIO);

	if (!buf) {

	if (!buf)

		return -ENOMEM;

	}



	clear &= ~set;	/* 'set' takes precedence over 'clear' */

	urb_value = 0;
@@ -568,6 +567,7 @@ static int update_mctrl(struct usb_serial_port *port, unsigned int set, unsigned 
				(clear & TIOCM_DTR) ? "LOW" : "unchanged",

				(set & TIOCM_RTS) ? "HIGH" :

				(clear & TIOCM_RTS) ? "LOW" : "unchanged");

		/* FIXME: locking on last_dtr_rts */

		priv->last_dtr_rts = (priv->last_dtr_rts & ~clear) | set;

	}

	return rv;