Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9a887162 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

USB: uvc_v4l2: cleanup test for end of loop 



We're trying to test for the the end of the loop here.  "format" is
never NULL.  We don't know what "format->fcc" is because we're past the
end of the loop and I think "fmt->fmt.pix.pixelformat" comes from the
user so we don't know what that is either.  It works, but it's cleaner
to just test to see if (i == ARRAY_SIZE(uvc_formats).

Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Acked-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 9ee47476

drivers/usb/gadget/uvc_v4l2.c

+1 −1
Original line number Diff line number Diff line
@@ -94,7 +94,7 @@ uvc_v4l2_set_format(struct uvc_video *video, struct v4l2_format *fmt) 
			break;

	}



	if (format == NULL || format->fcc != fmt->fmt.pix.pixelformat) {

	if (i == ARRAY_SIZE(uvc_formats)) {

		printk(KERN_INFO "Unsupported format 0x%08x.\n",

			fmt->fmt.pix.pixelformat);

		return -EINVAL;