Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 991bfef8 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Bjorn Helgaas
Browse files

PCI: dra7xx: Fix return value in case of error 



In dra7xx_pcie_init_irq_domain(), the pattern used to check and return
error is:

   if (!var) {
      dev_err(...);
      return PTR_ERR(var);
   }

So the returned value in case of error is always 0, which means 'success'.
Change it to return -ENODEV instead.

Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Reviewed-by: default avatarKishon Vijay Abraham I <kishon@ti.com>
parent af8c34ce

drivers/pci/host/pci-dra7xx.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -181,14 +181,14 @@ static int dra7xx_pcie_init_irq_domain(struct pcie_port *pp) 




	if (!pcie_intc_node) {

	if (!pcie_intc_node) {

		dev_err(dev, "No PCIe Intc node found\n");

		dev_err(dev, "No PCIe Intc node found\n");

		return PTR_ERR(pcie_intc_node);

		return -ENODEV;

	}

	}





	pp->irq_domain = irq_domain_add_linear(pcie_intc_node, 4,

	pp->irq_domain = irq_domain_add_linear(pcie_intc_node, 4,

					       &intx_domain_ops, pp);

					       &intx_domain_ops, pp);

	if (!pp->irq_domain) {

	if (!pp->irq_domain) {

		dev_err(dev, "Failed to get a INTx IRQ domain\n");

		dev_err(dev, "Failed to get a INTx IRQ domain\n");

		return PTR_ERR(pp->irq_domain);

		return -ENODEV;

	}

	}





	return 0;

	return 0;