Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 989038e2 authored by Nithin Sujir's avatar Nithin Sujir Committed by David S. Miller
Browse files

tg3: Don't turn off led on 5719 serdes port 0 



Turning off led on port 0 of the 5719 serdes causes all other ports to
lose power and stop functioning. Add tg3_phy_led_bug() function to check
for this condition. We use a switch() in tg3_phy_led_bug() for
consistency with the tg3_phy_power_bug() function.

Signed-off-by: default avatarNithin Nayak Sujir <nsujir@broadcom.com>
Signed-off-by: default avatarMichael Chan <mchan@broadcom.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 535a69e9

drivers/net/ethernet/broadcom/tg3.c

+16 −2
Original line number Diff line number Diff line
@@ -3030,6 +3030,19 @@ static bool tg3_phy_power_bug(struct tg3 *tp) 
	return false;

}



static bool tg3_phy_led_bug(struct tg3 *tp)

{

	switch (tg3_asic_rev(tp)) {

	case ASIC_REV_5719:

		if ((tp->phy_flags & TG3_PHYFLG_MII_SERDES) &&

		    !tp->pci_fn)

			return true;

		return false;

	}



	return false;

}



static void tg3_power_down_phy(struct tg3 *tp, bool do_low_power)

{

	u32 val;
@@ -3077,6 +3090,7 @@ static void tg3_power_down_phy(struct tg3 *tp, bool do_low_power) 
		}

		return;

	} else if (do_low_power) {

		if (!tg3_phy_led_bug(tp))

			tg3_writephy(tp, MII_TG3_EXT_CTRL,

				     MII_TG3_EXT_CTRL_FORCE_LED_OFF);