Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9825f376 authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab
Browse files

[media] jeilinj: fix return of the response code 



drivers/media/usb/gspca/jeilinj.c: In function 'jlj_read1':
drivers/media/usb/gspca/jeilinj.c:117:66: warning: parameter 'response' set but not used [-Wunused-but-set-parameter]
The code still doesn't make much sense, as response is never tested
there.

Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent ede4c3a5

drivers/media/usb/gspca/jeilinj.c

+3 −3
Original line number Diff line number Diff line
@@ -114,7 +114,7 @@ static void jlj_write2(struct gspca_dev *gspca_dev, unsigned char *command) 
}



/* Responses are one byte only */

static void jlj_read1(struct gspca_dev *gspca_dev, unsigned char response)

static void jlj_read1(struct gspca_dev *gspca_dev, unsigned char *response)

{

	int retval;
@@ -123,7 +123,7 @@ static void jlj_read1(struct gspca_dev *gspca_dev, unsigned char response) 
	retval = usb_bulk_msg(gspca_dev->dev,

	usb_rcvbulkpipe(gspca_dev->dev, 0x84),

				gspca_dev->usb_buf, 1, NULL, 500);

	response = gspca_dev->usb_buf[0];

	*response = gspca_dev->usb_buf[0];

	if (retval < 0) {

		pr_err("read command [%02x] error %d\n",

		       gspca_dev->usb_buf[0], retval);
@@ -260,7 +260,7 @@ static int jlj_start(struct gspca_dev *gspca_dev) 
		if (start_commands[i].delay)

			msleep(start_commands[i].delay);

		if (start_commands[i].ack_wanted)

			jlj_read1(gspca_dev, response);

			jlj_read1(gspca_dev, &response);

	}

	setcamquality(gspca_dev, v4l2_ctrl_g_ctrl(sd->jpegqual));

	msleep(2);