Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 97651ea6 authored by David Milburn's avatar David Milburn Committed by Jens Axboe
Browse files

mtip32xx: fix user_buffer check in exec_drive_command 



Current user_buffer check is incorrect and causes hdparm to fail

# hdparm -I /dev/rssda
 HDIO_DRIVE_CMD(identify) failed: Input/output error

/dev/rssda:

Patching linux-3.6-rc5 hdparm works as expected

# hdparm -I /dev/rssda
/dev/rssda:

ATA device, with non-removable media
	Model Number:       DELL_P320h-MTFDGAL350SAH
	Serial Number:      00000000121302025F01
	Firmware Revision:  B1442808
<snip>

Reported-by: default avatarTomas Henzl <thenzl@redhat.com>
Signed-off-by: default avatarDavid Milburn <dmilburn@redhat.com>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent ac64e657

drivers/block/mtip32xx/mtip32xx.c

+1 −1
Original line number Diff line number Diff line
@@ -1904,7 +1904,7 @@ static int exec_drive_command(struct mtip_port *port, u8 *command, 
	int rv = 0, xfer_sz = command[3];



	if (xfer_sz) {

		if (user_buffer)

		if (!user_buffer)

			return -EFAULT;



		buf = dmam_alloc_coherent(&port->dd->pdev->dev,