Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 96aacede authored by Antoine Tenart's avatar Antoine Tenart Committed by David S. Miller
Browse files

net: spider_net: avoid using signed char for bitops 



Signedness bugs may occur when using signed char for bitops,
depending on if the highest bit is ever used.

Signed-off-by: default avatarAntoine Tenart <antoine.tenart@free-electrons.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 0f6a6701

drivers/net/ethernet/toshiba/spider_net.c

+3 −3
Original line number Diff line number Diff line
@@ -1325,9 +1325,9 @@ spider_net_set_mac(struct net_device *netdev, void *p) 
	spider_net_write_reg(card, SPIDER_NET_GMACOPEMD, regvalue);



	/* write mac */

	macu = (addr->sa_data[0]<<24) + (addr->sa_data[1]<<16) +

		(addr->sa_data[2]<<8) + (addr->sa_data[3]);

	macl = (addr->sa_data[4]<<8) + (addr->sa_data[5]);

	macu = (netdev->dev_addr[0]<<24) + (netdev->dev_addr[1]<<16) +

		(netdev->dev_addr[2]<<8) + (netdev->dev_addr[3]);

	macl = (netdev->dev_addr[4]<<8) + (netdev->dev_addr[5]);

	spider_net_write_reg(card, SPIDER_NET_GMACUNIMACU, macu);

	spider_net_write_reg(card, SPIDER_NET_GMACUNIMACL, macl);