Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9637b86f authored by Wei Yongjun's avatar Wei Yongjun Committed by Mark Brown
Browse files

spi: bcm63xx: fix reference leak to master in bcm63xx_spi_remove() 



Once a spi_master_get() call succeeds, we need an additional
spi_master_put() call to free the memory, otherwise we will
leak a reference to master. Fix by removing the unnecessary
spi_master_get() call.

Fixes: 247263db ('spi: bcm63xx: use devm_spi_register_master()')
Signed-off-by: default avatarWei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: default avatarMark Brown <broonie@linaro.org>
parent 86b3bde0

drivers/spi/spi-bcm63xx.c

+1 −1
Original line number Diff line number Diff line
@@ -433,7 +433,7 @@ static int bcm63xx_spi_probe(struct platform_device *pdev) 


static int bcm63xx_spi_remove(struct platform_device *pdev)

{

	struct spi_master *master = spi_master_get(platform_get_drvdata(pdev));

	struct spi_master *master = platform_get_drvdata(pdev);

	struct bcm63xx_spi *bs = spi_master_get_devdata(master);



	/* reset spi block */