Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 950e2d51 authored by Peter Hurley's avatar Peter Hurley Committed by Gustavo Padovan
Browse files

Bluetooth: rfcomm: Fix lost wakeups waiting to accept socket 



Fix race conditions which can cause lost wakeups (or missed
signals) while waiting to accept an rfcomm socket connection.

Signed-off-by: default avatarPeter Hurley <peter@hurleysoftware.com>
Signed-off-by: default avatarGustavo F. Padovan <padovan@profusion.mobi>
parent e5842cdb

net/bluetooth/rfcomm/sock.c

+14 −14
Original line number Diff line number Diff line
@@ -485,11 +485,6 @@ static int rfcomm_sock_accept(struct socket *sock, struct socket *newsock, int f 


	lock_sock(sk);



	if (sk->sk_state != BT_LISTEN) {

		err = -EBADFD;

		goto done;

	}



	if (sk->sk_type != SOCK_STREAM) {

		err = -EINVAL;

		goto done;
@@ -501,19 +496,20 @@ static int rfcomm_sock_accept(struct socket *sock, struct socket *newsock, int f 


	/* Wait for an incoming connection. (wake-one). */

	add_wait_queue_exclusive(sk_sleep(sk), &wait);

	while (!(nsk = bt_accept_dequeue(sk, newsock))) {

	while (1) {

		set_current_state(TASK_INTERRUPTIBLE);

		if (!timeo) {

			err = -EAGAIN;



		if (sk->sk_state != BT_LISTEN) {

			err = -EBADFD;

			break;

		}



		release_sock(sk);

		timeo = schedule_timeout(timeo);

		lock_sock(sk);

		nsk = bt_accept_dequeue(sk, newsock);

		if (nsk)

			break;



		if (sk->sk_state != BT_LISTEN) {

			err = -EBADFD;

		if (!timeo) {

			err = -EAGAIN;

			break;

		}
@@ -521,8 +517,12 @@ static int rfcomm_sock_accept(struct socket *sock, struct socket *newsock, int f 
			err = sock_intr_errno(timeo);

			break;

		}



		release_sock(sk);

		timeo = schedule_timeout(timeo);

		lock_sock(sk);

	}

	set_current_state(TASK_RUNNING);

	__set_current_state(TASK_RUNNING);

	remove_wait_queue(sk_sleep(sk), &wait);



	if (err)