Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 94d4fe98 authored by Larry Finger's avatar Larry Finger Committed by John W. Linville
Browse files

rtl8187: Remove primitive write delays 



Each of the primary write routines, rtl8187_write_phy(),
rtl8225_write_bitbang(), and rtl8225_write_8051() all conclude with an
msleep() command. Testing shows that these are not needed.

Signed-off-by: default avatarLarry Finger <Larry.Finger@lwfinger.net>
Tested-by: default avatarHerton Ronaldo Krzesinski <herton@mandriva.com.br>
Tested-by: default avatarHin-Tak Leung <htl10@users.sourceforge.net>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 946d1c22

drivers/net/wireless/rtl8187_dev.c

+0 −2
Original line number Diff line number Diff line
@@ -152,8 +152,6 @@ void rtl8187_write_phy(struct ieee80211_hw *dev, u8 addr, u32 data) 
	rtl818x_iowrite8(priv, &priv->map->PHY[2], (data >> 16) & 0xFF);

	rtl818x_iowrite8(priv, &priv->map->PHY[1], (data >> 8) & 0xFF);

	rtl818x_iowrite8(priv, &priv->map->PHY[0], data & 0xFF);



	msleep(1);

}



static void rtl8187_tx_cb(struct urb *urb)

drivers/net/wireless/rtl8187_rtl8225.c

+0 −2
Original line number Diff line number Diff line
@@ -64,7 +64,6 @@ static void rtl8225_write_bitbang(struct ieee80211_hw *dev, u8 addr, u16 data) 


	rtl818x_iowrite16(priv, &priv->map->RFPinsOutput, reg80 | (1 << 2));

	rtl818x_iowrite16(priv, &priv->map->RFPinsSelect, reg84);

	msleep(2);

}



static void rtl8225_write_8051(struct ieee80211_hw *dev, u8 addr, __le16 data)
@@ -98,7 +97,6 @@ static void rtl8225_write_8051(struct ieee80211_hw *dev, u8 addr, __le16 data) 


	rtl818x_iowrite16(priv, &priv->map->RFPinsOutput, reg80 | (1 << 2));

	rtl818x_iowrite16(priv, &priv->map->RFPinsSelect, reg84);

	msleep(2);

}



static void rtl8225_write(struct ieee80211_hw *dev, u8 addr, u16 data)