Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9458120e authored by Rob Herring's avatar Rob Herring Committed by Linus Walleij
Browse files

pinctrl: kill off set_irq_flags usage 



set_irq_flags is ARM specific with custom flags which have genirq
equivalents. Convert drivers to use the genirq interfaces directly, so we
can kill off set_irq_flags. The translation of flags is as follows:

IRQF_VALID -> !IRQ_NOREQUEST
IRQF_PROBE -> !IRQ_NOPROBE
IRQF_NOAUTOEN -> IRQ_NOAUTOEN

For IRQs managed by an irqdomain, the irqdomain core code handles clearing
and setting IRQ_NOREQUEST already, so there is no need to do this in
.map() functions and we can simply remove the set_irq_flags calls. Some
users also modify IRQ_NOPROBE and this has been maintained although it
is not clear that is really needed. There appears to be a great deal of
blind copy and paste of this code.

Signed-off-by: default avatarRob Herring <robh@kernel.org>
Cc: Stephen Warren <swarren@wwwdotorg.org>
Cc: Lee Jones <lee@kernel.org>
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: Tomasz Figa <tomasz.figa@gmail.com>
Cc: Thomas Abraham <thomas.abraham@linaro.org>
Cc: Kukjin Kim <kgene@kernel.org>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: linux-gpio@vger.kernel.org
Cc: linux-rpi-kernel@lists.infradead.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-mediatek@lists.infradead.org
Cc: linux-samsung-soc@vger.kernel.org
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 802bb9b6

drivers/pinctrl/bcm/pinctrl-bcm2835.c

+0 −1
Original line number Diff line number Diff line
@@ -987,7 +987,6 @@ static int bcm2835_pinctrl_probe(struct platform_device *pdev) 
		irq_set_chip_and_handler(irq, &bcm2835_gpio_irq_chip,

				handle_level_irq);

		irq_set_chip_data(irq, pc);

		set_irq_flags(irq, IRQF_VALID);

	}



	for (i = 0; i < BCM2835_NUM_BANKS; i++) {

drivers/pinctrl/mediatek/pinctrl-mtk-common.c

+0 −2
Original line number Diff line number Diff line
@@ -1348,11 +1348,9 @@ int mtk_pctrl_init(struct platform_device *pdev, 
		irq_set_chip_and_handler(virq, &mtk_pinctrl_irq_chip,

			handle_level_irq);

		irq_set_chip_data(virq, pctl);

		set_irq_flags(virq, IRQF_VALID);

	};



	irq_set_chained_handler_and_data(irq, mtk_eint_irq_handler, pctl);

	set_irq_flags(irq, IRQF_VALID);

	return 0;



chip_error:

drivers/pinctrl/pinctrl-single.c

+0 −5
Original line number Diff line number Diff line
@@ -1716,12 +1716,7 @@ static int pcs_irqdomain_map(struct irq_domain *d, unsigned int irq, 
	irq_set_chip_data(irq, pcs_soc);

	irq_set_chip_and_handler(irq, &pcs->chip,

				 handle_level_irq);



#ifdef CONFIG_ARM

	set_irq_flags(irq, IRQF_VALID);

#else

	irq_set_noprobe(irq);

#endif



	return 0;

}

drivers/pinctrl/samsung/pinctrl-exynos.c

+0 −1
Original line number Diff line number Diff line
@@ -256,7 +256,6 @@ static int exynos_eint_irq_map(struct irq_domain *h, unsigned int virq, 
	irq_set_chip_data(virq, b);

	irq_set_chip_and_handler(virq, &b->irq_chip->chip,

					handle_level_irq);

	set_irq_flags(virq, IRQF_VALID);

	return 0;

}

drivers/pinctrl/samsung/pinctrl-exynos5440.c

+0 −1
Original line number Diff line number Diff line
@@ -894,7 +894,6 @@ static int exynos5440_gpio_irq_map(struct irq_domain *h, unsigned int virq, 
	irq_set_chip_data(virq, d);

	irq_set_chip_and_handler(virq, &exynos5440_gpio_irq_chip,

					handle_level_irq);

	set_irq_flags(virq, IRQF_VALID);

	return 0;

}