Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 94215ccd authored by Jarod Wilson's avatar Jarod Wilson Committed by Mauro Carvalho Chehab
Browse files

[media] imon: fix initial panel key repeat suppression 



As pointed out on the lirc list by Andreas Dick, initial panel key
repeat suppression wasn't working, as we had no timevals accumulated
until after the first repeat. Also add a missing locking call.

Signed-off-by: default avatarJarod Wilson <jarod@redhat.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 443b3919

drivers/media/rc/imon.c

+4 −2
Original line number Diff line number Diff line
@@ -1590,16 +1590,16 @@ static void imon_incoming_packet(struct imon_context *ictx, 
	/* Only panel type events left to process now */

	spin_lock_irqsave(&ictx->kc_lock, flags);



	do_gettimeofday(&t);

	/* KEY_MUTE repeats from knob need to be suppressed */

	if (ictx->kc == KEY_MUTE && ictx->kc == ictx->last_keycode) {

		do_gettimeofday(&t);

		msec = tv2int(&t, &prev_time);

		prev_time = t;

		if (msec < ictx->idev->rep[REP_DELAY]) {

			spin_unlock_irqrestore(&ictx->kc_lock, flags);

			return;

		}

	}

	prev_time = t;

	kc = ictx->kc;



	spin_unlock_irqrestore(&ictx->kc_lock, flags);
@@ -1611,7 +1611,9 @@ static void imon_incoming_packet(struct imon_context *ictx, 
	input_report_key(ictx->idev, kc, 0);

	input_sync(ictx->idev);



	spin_lock_irqsave(&ictx->kc_lock, flags);

	ictx->last_keycode = kc;

	spin_unlock_irqrestore(&ictx->kc_lock, flags);



	return;