Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 91c18325 authored by Vedang Patel's avatar Vedang Patel Committed by Mark Brown
Browse files

ASoC: Intel: Skylake: Increase loglevel of debug messages. 



There is log spam while doing playback, record or reloading the
audio firmware.

print_hex_dump uses printk(KERN_DEBUG,... which is different from
dev_dbg used elsewhere in the driver: it's always enabled at
compile-time. Change it to print_hex_dump_debug for logging consistency.

For consistency with other log statements, change dev_info to dev_dbg
for a kernel print which is frequently printed by the driver.

Signed-off-by: default avatarVedang Patel <vedang.patel@intel.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent ef06b6f3

sound/soc/intel/skylake/skl-messages.c

+1 −1
Original line number Diff line number Diff line
@@ -730,7 +730,7 @@ static int skl_set_module_format(struct skl_sst *ctx, 


	dev_dbg(ctx->dev, "Module type=%d config size: %d bytes\n",

			module_config->id.module_id, param_size);

	print_hex_dump(KERN_DEBUG, "Module params:", DUMP_PREFIX_OFFSET, 8, 4,

	print_hex_dump_debug("Module params:", DUMP_PREFIX_OFFSET, 8, 4,

			*param_data, param_size, false);

	return 0;

}

sound/soc/intel/skylake/skl-sst-ipc.c

+2 −2
Original line number Diff line number Diff line
@@ -363,7 +363,7 @@ static void skl_ipc_process_reply(struct sst_generic_ipc *ipc, 
	/* first process the header */

	switch (reply) {

	case IPC_GLB_REPLY_SUCCESS:

		dev_info(ipc->dev, "ipc FW reply %x: success\n", header.primary);

		dev_dbg(ipc->dev, "ipc FW reply %x: success\n", header.primary);

		/* copy the rx data from the mailbox */

		sst_dsp_inbox_read(ipc->dsp, msg->rx_data, msg->rx_size);

		break;
@@ -692,7 +692,7 @@ int skl_ipc_init_instance(struct sst_generic_ipc *ipc, 
	 /* param_block_size must be in dwords */

	u16 param_block_size = msg->param_data_size / sizeof(u32);



	print_hex_dump(KERN_DEBUG, NULL, DUMP_PREFIX_NONE,

	print_hex_dump_debug(NULL, DUMP_PREFIX_NONE,

		16, 4, buffer, param_block_size, false);



	header.primary = IPC_MSG_TARGET(IPC_MOD_MSG);