Commit 91a72a70 authored Jul 14, 2010 by Doug Kehn Committed by David S. Miller Jul 14, 2010

net/core: neighbour update Oops



When configuring DMVPN (GRE + openNHRP) and a GRE remote
address is configured a kernel Oops is observed.  The
obserseved Oops is caused by a NULL header_ops pointer
(neigh->dev->header_ops) in neigh_update_hhs() when

void (*update)(struct hh_cache*, const struct net_device*, const unsigned char *)
= neigh->dev->header_ops->cache_update;

is executed.  The dev associated with the NULL header_ops is
the GRE interface.  This patch guards against the
possibility that header_ops is NULL.

This Oops was first observed in kernel version 2.6.26.8.

Signed-off-by: Doug Kehn <rdkehn@yahoo.com>
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 87fd308c

net/core/neighbour.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -949,7 +949,10 @@ static void neigh_update_hhs(struct neighbour *neigh)
		{
		struct hh_cache *hh;
		void (update)(struct hh_cache, const struct net_device, const unsigned char )
		= neigh->dev->header_ops->cache_update;
		= NULL;

		if (neigh->dev->header_ops)
		update = neigh->dev->header_ops->cache_update;

		if (update) {
		for (hh = neigh->hh; hh; hh = hh->hh_next) {