Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9188dbae authored by Benjamin Tissoires's avatar Benjamin Tissoires Committed by Jiri Kosina
Browse files

HID: logitech-hidpp: add a module parameter to keep firmware gestures 



The Logitech T650 used to report 3 fingers swipes to the up as a press on the
Super key. When we switched the touchpad to the raw mode, we also disable such
firmware gesture and some users may rely on it.

Unfortunately, 3 finger swipes are still not supported in most of the Linux
environments, which means that we disabled a feature of the touchpad.

Allow users to revert the raw reporting mode and keep going with the firmware
gestures by providing a new module parameter.

Signed-off-by: default avatarBenjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent c1740d13

drivers/hid/hid-logitech-hidpp.c

+10 −0
Original line number Diff line number Diff line
@@ -28,6 +28,11 @@ MODULE_LICENSE("GPL"); 
MODULE_AUTHOR("Benjamin Tissoires <benjamin.tissoires@gmail.com>");

MODULE_AUTHOR("Nestor Lopez Casado <nlopezcasad@logitech.com>");



static bool disable_raw_mode;

module_param(disable_raw_mode, bool, 0644);

MODULE_PARM_DESC(disable_raw_mode,

	"Disable Raw mode reporting for touchpads and keep firmware gestures.");



#define REPORT_ID_HIDPP_SHORT			0x10

#define REPORT_ID_HIDPP_LONG			0x11
@@ -1188,6 +1193,11 @@ static int hidpp_probe(struct hid_device *hdev, const struct hid_device_id *id) 


	hidpp->quirks = id->driver_data;



	if (disable_raw_mode) {

		hidpp->quirks &= ~HIDPP_QUIRK_CLASS_WTP;

		hidpp->quirks &= ~HIDPP_QUIRK_DELAYED_INIT;

	}



	if (hidpp->quirks & HIDPP_QUIRK_CLASS_WTP) {

		ret = wtp_allocate(hdev, id);

		if (ret)