Commit 9172b763 authored Jun 19, 2014 by Maurizio Lombardi Committed by Christoph Hellwig Jun 25, 2014

bnx2fc: do not scan uninitialized lists in case of error.



In case of of error, the bnx2fc_cmd_mgr_alloc() function will call
the bnx2fc_cmd_mgr_free() to perform the cleanup.
The problem is that in one case the latter may try to scan
some not-yet initialized lists, resulting in a kernel panic.

This patch prevents this from happening by freeing the lists
before calling bnx2fc_cmd_mgr_free().

Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
Acked-by: Eddie Wai <eddie.wai@broadcom.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>

parent 0353e085

drivers/scsi/bnx2fc/bnx2fc_io.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -282,6 +282,8 @@ struct bnx2fc_cmd_mgr bnx2fc_cmd_mgr_alloc(struct bnx2fc_hba hba)
		arr_sz, GFP_KERNEL);
		if (!cmgr->free_list_lock) {
		printk(KERN_ERR PFX "failed to alloc free_list_lock\n");
		kfree(cmgr->free_list);
		cmgr->free_list = NULL;
		goto mem_err;
		}