Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 916e4cf4 authored by Hannes Frederic Sowa's avatar Hannes Frederic Sowa Committed by David S. Miller
Browse files

ipv6: reuse ip6_frag_id from ip6_ufo_append_data 



Currently we generate a new fragmentation id on UFO segmentation. It
is pretty hairy to identify the correct net namespace and dst there.
Especially tunnels use IFF_XMIT_DST_RELEASE and thus have no skb_dst
available at all.

This causes unreliable or very predictable ipv6 fragmentation id
generation while segmentation.

Luckily we already have pregenerated the ip6_frag_id in
ip6_ufo_append_data and can use it here.

Signed-off-by: default avatarHannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 4c47af4d

net/ipv6/udp_offload.c

+1 −1
Original line number Diff line number Diff line
@@ -113,7 +113,7 @@ static struct sk_buff *udp6_ufo_fragment(struct sk_buff *skb, 
		fptr = (struct frag_hdr *)(skb_network_header(skb) + unfrag_ip6hlen);

		fptr->nexthdr = nexthdr;

		fptr->reserved = 0;

		ipv6_select_ident(fptr, (struct rt6_info *)skb_dst(skb));

		fptr->identification = skb_shinfo(skb)->ip6_frag_id;



		/* Fragment the skb. ipv6 header and the remaining fields of the

		 * fragment header are updated in ipv6_gso_segment()