Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 91021689 authored by Eduardo Valentin's avatar Eduardo Valentin Committed by Greg Kroah-Hartman
Browse files

staging: omap-thermal: refactor temp_sensor_unmask_interrupts 



This change improves temp_sensor_unmask_interrupts by:
. renaming it to omap_bandgap_unmask_interrupts
. making it a void function, as there is nothing really to report an error.

Signed-off-by: default avatarEduardo Valentin <eduardo.valentin@ti.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f8ccce20

drivers/staging/omap-thermal/omap-bandgap.c

+8 −6
Original line number Diff line number Diff line
@@ -338,7 +338,7 @@ int omap_bandgap_add_hyst(struct omap_bandgap *bg_ptr, int adc_val, 
/***   Helper functions handling device Alert/Shutdown signals   ***/



/* Talert masks. Call it only if HAS(TALERT) is set */

static int temp_sensor_unmask_interrupts(struct omap_bandgap *bg_ptr, int id,

static void omap_bandgap_unmask_interrupts(struct omap_bandgap *bg_ptr, int id,

					   u32 t_hot, u32 t_cold)

{

	struct temp_sensor_registers *tsr;
@@ -360,8 +360,6 @@ static int temp_sensor_unmask_interrupts(struct omap_bandgap *bg_ptr, int id, 
	else

		reg_val &= ~tsr->mask_cold_mask;

	omap_bandgap_writel(bg_ptr, reg_val, tsr->bgap_mask_ctrl);



	return 0;

}



/* Talert Thot threshold. Call it only if HAS(TALERT) is set */
@@ -399,7 +397,9 @@ int temp_sensor_configure_thot(struct omap_bandgap *bg_ptr, int id, int t_hot) 
		return -EIO;

	}



	return temp_sensor_unmask_interrupts(bg_ptr, id, t_hot, cold);

	omap_bandgap_unmask_interrupts(bg_ptr, id, t_hot, cold);



	return 0;

}



/* Talert Tcold threshold. Call it only if HAS(TALERT) is set */
@@ -438,7 +438,9 @@ int temp_sensor_configure_tcold(struct omap_bandgap *bg_ptr, int id, 
		return -EIO;

	}



	return temp_sensor_unmask_interrupts(bg_ptr, id, hot, t_cold);

	omap_bandgap_unmask_interrupts(bg_ptr, id, hot, t_cold);



	return 0;

}



#define bandgap_is_valid(b)						\