Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8fefbb75 authored by Sean Paul's avatar Sean Paul Committed by Florian Tobias Schandinat
Browse files

video: exynos_dp: Change aux transaction failures 



This patch adds the function name to aux transaction failure messages
so we can tell which transaction is failing. It also changes the level
of Aux Transaction fail messages from error to debug. We retry the
transactions a few times and will report errors if warranted outside of
this function.

Signed-off-by: default avatarSean Paul <seanpaul@chromium.org>
Reviewed-by: default avatarDoug Anderson <dianders@chromium.org>
Reviewed-by: default avatarBernie Thompson <bhthompson@chromium.org>
Acked-by: default avatarJingoo Han <jg1.han@samsung.com>
Signed-off-by: default avatarFlorian Tobias Schandinat <FlorianSchandinat@gmx.de>
parent 11bce645

drivers/video/exynos/exynos_dp_reg.c

+14 −7
Original line number Diff line number Diff line
@@ -479,7 +479,8 @@ int exynos_dp_write_byte_to_dpcd(struct exynos_dp_device *dp, 
		if (retval == 0)

			break;

		else

			dev_err(dp->dev, "Aux Transaction fail!\n");

			dev_dbg(dp->dev, "%s: Aux Transaction fail!\n",

				__func__);

	}



	return retval;
@@ -519,7 +520,8 @@ int exynos_dp_read_byte_from_dpcd(struct exynos_dp_device *dp, 
		if (retval == 0)

			break;

		else

			dev_err(dp->dev, "Aux Transaction fail!\n");

			dev_dbg(dp->dev, "%s: Aux Transaction fail!\n",

				__func__);

	}



	/* Read data buffer */
@@ -583,7 +585,8 @@ int exynos_dp_write_bytes_to_dpcd(struct exynos_dp_device *dp, 
			if (retval == 0)

				break;

			else

				dev_err(dp->dev, "Aux Transaction fail!\n");

				dev_dbg(dp->dev, "%s: Aux Transaction fail!\n",

					__func__);

		}



		start_offset += cur_data_count;
@@ -640,7 +643,8 @@ int exynos_dp_read_bytes_from_dpcd(struct exynos_dp_device *dp, 
			if (retval == 0)

				break;

			else

				dev_err(dp->dev, "Aux Transaction fail!\n");

				dev_dbg(dp->dev, "%s: Aux Transaction fail!\n",

					__func__);

		}



		for (cur_data_idx = 0; cur_data_idx < cur_data_count;
@@ -685,7 +689,7 @@ int exynos_dp_select_i2c_device(struct exynos_dp_device *dp, 
	/* Start AUX transaction */

	retval = exynos_dp_start_aux_transaction(dp);

	if (retval != 0)

		dev_err(dp->dev, "Aux Transaction fail!\n");

		dev_dbg(dp->dev, "%s: Aux Transaction fail!\n", __func__);



	return retval;

}
@@ -725,7 +729,8 @@ int exynos_dp_read_byte_from_i2c(struct exynos_dp_device *dp, 
		if (retval == 0)

			break;

		else

			dev_err(dp->dev, "Aux Transaction fail!\n");

			dev_dbg(dp->dev, "%s: Aux Transaction fail!\n",

				__func__);

	}



	/* Read data */
@@ -785,7 +790,9 @@ int exynos_dp_read_bytes_from_i2c(struct exynos_dp_device *dp, 
				if (retval == 0)

					break;

				else

					dev_err(dp->dev, "Aux Transaction fail!\n");

					dev_dbg(dp->dev,

						"%s: Aux Transaction fail!\n",

						__func__);

			}

			/* Check if Rx sends defer */

			reg = readl(dp->reg_base + EXYNOS_DP_AUX_RX_COMM);