Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8fa58af7 authored by Karsten Wiese's avatar Karsten Wiese Committed by Jaroslav Kysela
Browse files

[ALSA] snd_hwdep_release() racefix 



snd_card_file_remove() can free the snd_card.
Touch hw->* only before calling snd_card_file_remove().
Unrelated: Allow hwdep devices not to have own ops.release();

Signed-off-by: default avatarKarsten Wiese <fzu@wemgehoertderstaat.de>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarJaroslav Kysela <perex@suse.cz>
parent 298a2c75

sound/core/hwdep.c

+5 −4
Original line number Diff line number Diff line
@@ -156,15 +156,16 @@ static int snd_hwdep_release(struct inode *inode, struct file * file) 
	int err = -ENXIO;

	struct snd_hwdep *hw = file->private_data;

	struct module *mod = hw->card->module;



	mutex_lock(&hw->open_mutex);

	if (hw->ops.release) {

	if (hw->ops.release)

		err = hw->ops.release(hw, file);

		wake_up(&hw->open_wait);

	}

	if (hw->used > 0)

		hw->used--;

	snd_card_file_remove(hw->card, file);

	mutex_unlock(&hw->open_mutex);

	wake_up(&hw->open_wait);



	snd_card_file_remove(hw->card, file);

	module_put(mod);

	return err;

}