Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8eb2d829 authored by Li Zefan's avatar Li Zefan
Browse files

btrfs: Fix threshold calculation for block groups smaller than 1GB 



If a block group is smaller than 1GB, the extent entry threadhold
calculation will always set the threshold to 0.

So as free space gets fragmented, btrfs will switch to use bitmap
to manage free space, but then will never switch back to extents
due to this bug.

Reviewed-by: default avatarJosef Bacik <josef@redhat.com>
Signed-off-by: default avatarLi Zefan <lizf@cn.fujitsu.com>
parent 65e5341b

fs/btrfs/free-space-cache.c

+6 −2
Original line number Diff line number Diff line
@@ -1016,14 +1016,18 @@ static void recalculate_thresholds(struct btrfs_block_group_cache *block_group) 
	u64 max_bytes;

	u64 bitmap_bytes;

	u64 extent_bytes;

	u64 size = block_group->key.offset;



	/*

	 * The goal is to keep the total amount of memory used per 1gb of space

	 * at or below 32k, so we need to adjust how much memory we allow to be

	 * used by extent based free space tracking

	 */

	if (size < 1024 * 1024 * 1024)

		max_bytes = MAX_CACHE_BYTES_PER_GIG;

	else

		max_bytes = MAX_CACHE_BYTES_PER_GIG *

		(div64_u64(block_group->key.offset, 1024 * 1024 * 1024));

			div64_u64(size, 1024 * 1024 * 1024);



	/*

	 * we want to account for 1 more bitmap than what we have so we can make