Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8e046d68 authored by Karicheri, Muralidharan's avatar Karicheri, Muralidharan Committed by David S. Miller
Browse files

net: netcp: remove call to netif_carrier_(on/off) for MAC to Phy interface 



Currently when interface type is MAC to Phy, netif_carrier_(on/off)
is called which is not needed as Phy lib already updates the carrier
status to net stack. This is needed only for other interface types

Signed-off-by: default avatarMurali Karicheri <m-karicheri2@ti.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2decb268

drivers/net/ethernet/ti/netcp_ethss.c

+6 −2
Original line number Diff line number Diff line
@@ -1765,7 +1765,9 @@ static void netcp_ethss_link_state_action(struct gbe_priv *gbe_dev, 
				     ALE_PORT_STATE,

				     ALE_PORT_STATE_FORWARD);



		if (ndev && slave->open)

		if (ndev && slave->open &&

		    slave->link_interface != SGMII_LINK_MAC_PHY &&

		    slave->link_interface != XGMII_LINK_MAC_PHY)

			netif_carrier_on(ndev);

	} else {

		writel(mac_control, GBE_REG_ADDR(slave, emac_regs,
@@ -1773,7 +1775,9 @@ static void netcp_ethss_link_state_action(struct gbe_priv *gbe_dev, 
		cpsw_ale_control_set(gbe_dev->ale, slave->port_num,

				     ALE_PORT_STATE,

				     ALE_PORT_STATE_DISABLE);

		if (ndev)

		if (ndev &&

		    slave->link_interface != SGMII_LINK_MAC_PHY &&

		    slave->link_interface != XGMII_LINK_MAC_PHY)

			netif_carrier_off(ndev);

	}