Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8df59918 authored by Jarod Wilson's avatar Jarod Wilson Committed by Mauro Carvalho Chehab
Browse files

[media] ir-kbd-i2c: improve remote behavior with z8 behind usb 



Add the same "are you ready?" i2c_master_send() poll command to
get_key_haup_xvr found in lirc_zilog, which is apparently seen in
the Windows driver for the PVR-150 w/a z8. This stabilizes what is
received from both the HD-PVR and HVR-1950, even with their polling
intervals at the default of 100, thus the removal of the custom
260ms polling_interval in pvrusb2-i2c-core.c.

Acked-by: default avatarAndy Walls <awalls@md.metrocast.net>
Acked-by: default avatarMike Isely <isely@isely.net>
Signed-off-by: default avatarJarod Wilson <jarod@redhat.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 5766d204

drivers/media/video/ir-kbd-i2c.c

+13 −0
Original line number Diff line number Diff line
@@ -128,6 +128,19 @@ static int get_key_haup(struct IR_i2c *ir, u32 *ir_key, u32 *ir_raw) 


static int get_key_haup_xvr(struct IR_i2c *ir, u32 *ir_key, u32 *ir_raw)

{

	int ret;

	unsigned char buf[1] = { 0 };



	/*

	 * This is the same apparent "are you ready?" poll command observed

	 * watching Windows driver traffic and implemented in lirc_zilog. With

	 * this added, we get far saner remote behavior with z8 chips on usb

	 * connected devices, even with the default polling interval of 100ms.

	 */

	ret = i2c_master_send(ir->c, buf, 1);

	if (ret != 1)

		return (ret < 0) ? ret : -EINVAL;



	return get_key_haup_common (ir, ir_key, ir_raw, 6, 3);

}

drivers/media/video/pvrusb2/pvrusb2-i2c-core.c

+0 −1
Original line number Diff line number Diff line
@@ -597,7 +597,6 @@ static void pvr2_i2c_register_ir(struct pvr2_hdw *hdw) 
		init_data->internal_get_key_func = IR_KBD_GET_KEY_HAUP_XVR;

		init_data->type                  = RC_TYPE_RC5;

		init_data->name                  = hdw->hdw_desc->description;

		init_data->polling_interval      = 260; /* ms From lirc_zilog */

		/* IR Receiver */

		info.addr          = 0x71;

		info.platform_data = init_data;