Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8c608a32 authored by Roland Dreier's avatar Roland Dreier
Browse files

[IPoIB] no need to set skb->dev right before freeing skb 



For cut-and-paste reasons, the IPoIB driver was setting skb->dev right
before calling dev_kfree_skb_any().  Get rid of this.

Signed-off-by: default avatarRoland Dreier <rolandd@cisco.com>
parent 2f76e829

drivers/infiniband/ulp/ipoib/ipoib_multicast.c

+4 −13
Original line number Diff line number Diff line
@@ -120,12 +120,8 @@ static void ipoib_mcast_free(struct ipoib_mcast *mcast) 
	if (mcast->ah)

		ipoib_put_ah(mcast->ah);



	while (!skb_queue_empty(&mcast->pkt_queue)) {

		struct sk_buff *skb = skb_dequeue(&mcast->pkt_queue);



		skb->dev = dev;

		dev_kfree_skb_any(skb);

	}

	while (!skb_queue_empty(&mcast->pkt_queue))

		dev_kfree_skb_any(skb_dequeue(&mcast->pkt_queue));



	kfree(mcast);

}
@@ -317,13 +313,8 @@ ipoib_mcast_sendonly_join_complete(int status, 
					IPOIB_GID_ARG(mcast->mcmember.mgid), status);



		/* Flush out any queued packets */

		while (!skb_queue_empty(&mcast->pkt_queue)) {

			struct sk_buff *skb = skb_dequeue(&mcast->pkt_queue);



			skb->dev = dev;



			dev_kfree_skb_any(skb);

		}

		while (!skb_queue_empty(&mcast->pkt_queue))

			dev_kfree_skb_any(skb_dequeue(&mcast->pkt_queue));



		/* Clear the busy flag so we try again */

		clear_bit(IPOIB_MCAST_FLAG_BUSY, &mcast->flags);