Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8c36e9df authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Al Viro
Browse files

cifs: avoid unused variable and label 



The newly introduced cifs_clone_file_range() function produces
two harmless compile-time warnings:

cifsfs.c: In function 'cifs_clone_file_range':
cifsfs.c:963:1: warning: label 'out_unlock' defined but not used [-Wunused-label]
cifsfs.c:924:20: warning: unused variable 'src_tcon' [-Wunused-variable]

In both cases, removing the extraneous line avoids the warning.

Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Fixes: c6f2a1e2e5f8 ("vfs: pull btrfs clone API to vfs layer")
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent ffa0160a

fs/cifs/cifsfs.c

+0 −2
Original line number Diff line number Diff line
@@ -921,7 +921,6 @@ static int cifs_clone_file_range(struct file *src_file, loff_t off, 
	struct inode *target_inode = file_inode(dst_file);

	struct cifsFileInfo *smb_file_src = src_file->private_data;

	struct cifsFileInfo *smb_file_target = dst_file->private_data;

	struct cifs_tcon *src_tcon = tlink_tcon(smb_file_src->tlink);

	struct cifs_tcon *target_tcon = tlink_tcon(smb_file_target->tlink);

	unsigned int xid;

	int rc;
@@ -960,7 +959,6 @@ static int cifs_clone_file_range(struct file *src_file, loff_t off, 
	/* force revalidate of size and timestamps of target file now

	   that target is updated on the server */

	CIFS_I(target_inode)->time = 0;

out_unlock:

	/* although unlocking in the reverse order from locking is not

	   strictly necessary here it is a little cleaner to be consistent */

	unlock_two_nondirectories(src_inode, target_inode);