Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8c0a8537 authored Sep 26, 2012 by Kirill A. Shutemov Committed by Al Viro Oct 02, 2012

fs: push rcu_barrier() from deactivate_locked_super() to filesystems



There's no reason to call rcu_barrier() on every
deactivate_locked_super().  We only need to make sure that all delayed rcu
free inodes are flushed before we destroy related cache.

Removing rcu_barrier() from deactivate_locked_super() affects some fast
paths.  E.g.  on my machine exit_group() of a last process in IPC
namespace takes 0.07538s.  rcu_barrier() takes 0.05188s of that time.

Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

parent 99621b44

fs/9p/v9fs.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -560,6 +560,11 @@ static int v9fs_init_inode_cache(void)
		*/
		static void v9fs_destroy_inode_cache(void)
		{
		/*
		* Make sure all delayed rcu free inodes are flushed before we
		* destroy cache.
		*/
		rcu_barrier();
		kmem_cache_destroy(v9fs_inode_cache);
		}

fs/adfs/super.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -275,6 +275,11 @@ static int init_inodecache(void)

		static void destroy_inodecache(void)
		{
		/*
		* Make sure all delayed rcu free inodes are flushed before we
		* destroy cache.
		*/
		rcu_barrier();
		kmem_cache_destroy(adfs_inode_cachep);
		}

fs/affs/super.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -147,6 +147,11 @@ static int init_inodecache(void)

		static void destroy_inodecache(void)
		{
		/*
		* Make sure all delayed rcu free inodes are flushed before we
		* destroy cache.
		*/
		rcu_barrier();
		kmem_cache_destroy(affs_inode_cachep);
		}

fs/afs/super.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -123,6 +123,11 @@ void __exit afs_fs_exit(void)
		BUG();
		}

		/*
		* Make sure all delayed rcu free inodes are flushed before we
		* destroy cache.
		*/
		rcu_barrier();
		kmem_cache_destroy(afs_inode_cachep);
		_leave("");
		}

fs/befs/linuxvfs.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -454,6 +454,11 @@ befs_init_inodecache(void)
		static void
		befs_destroy_inodecache(void)
		{
		/*
		* Make sure all delayed rcu free inodes are flushed before we
		* destroy cache.
		*/
		rcu_barrier();
		kmem_cache_destroy(befs_inode_cachep);
		}