Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8bf69aae authored by Ohad Ben-Cohen's avatar Ohad Ben-Cohen Committed by Luciano Coelho
Browse files

wl12xx: fix "JOIN while associated" commentary 



Issuing multiple JOIN commands to the wl12xx's firmware, while
we're associated, might have undesired implications, so the driver
prints a message when that happens, and warn developers who check
out the source.

Update the commentary in order to consider the one valid scenario
where this can happen: roaming.

Cautiously keep the message for now, until we either gain confidence
there are no unintentional JOIN-while-associated events, or until
we move to the new multi-role fw who solves this multiple-join issue
for good.

Signed-off-by: default avatarOhad Ben-Cohen <ohad@wizery.com>
Signed-off-by: default avatarLuciano Coelho <coelho@ti.com>
parent c5745187

drivers/net/wireless/wl12xx/main.c

+4 −4
Original line number Diff line number Diff line
@@ -1591,10 +1591,10 @@ static int wl1271_join(struct wl1271 *wl, bool set_assoc) 
	 * One of the side effects of the JOIN command is that is clears

	 * WPA/WPA2 keys from the chipset. Performing a JOIN while associated

	 * to a WPA/WPA2 access point will therefore kill the data-path.

	 * Currently there is no supported scenario for JOIN during

	 * association - if it becomes a supported scenario, the WPA/WPA2 keys

	 * must be handled somehow.

	 *

	 * Currently the only valid scenario for JOIN during association

	 * is on roaming, in which case we will also be given new keys.

	 * Keep the below message for now, unless it starts bothering

	 * users who really like to roam a lot :)

	 */

	if (test_bit(WL1271_FLAG_STA_ASSOCIATED, &wl->flags))

		wl1271_info("JOIN while associated.");