Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8bc3b1e6 authored by David Moore's avatar David Moore Committed by Theodore Ts'o
Browse files

ext4: BUG_ON assertion repeated for inode1, not done for inode2 



During a source code review of fs/ext4/extents.c I noted identical
consecutive lines. An assertion is repeated for inode1 and never done
for inode2. This is not in keeping with the rest of the code in the
ext4_swap_extents function and appears to be a bug.

Assert that the inode2 mutex is not locked.

Signed-off-by: default avatarDavid Moore <dmoorefo@gmail.com>
Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
Reviewed-by: default avatarEric Sandeen <sandeen@redhat.com>
parent ad0a0ce8

fs/ext4/extents.c

+1 −1
Original line number Diff line number Diff line
@@ -5542,7 +5542,7 @@ ext4_swap_extents(handle_t *handle, struct inode *inode1, 
	BUG_ON(!rwsem_is_locked(&EXT4_I(inode1)->i_data_sem));

	BUG_ON(!rwsem_is_locked(&EXT4_I(inode2)->i_data_sem));

	BUG_ON(!mutex_is_locked(&inode1->i_mutex));

	BUG_ON(!mutex_is_locked(&inode1->i_mutex));

	BUG_ON(!mutex_is_locked(&inode2->i_mutex));



	*erp = ext4_es_remove_extent(inode1, lblk1, count);

	if (unlikely(*erp))