Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8b97c7c2 authored by Julia Lawall's avatar Julia Lawall Committed by David S. Miller
Browse files

drivers/atm: Use DIV_ROUND_CLOSEST 

The kernel.h macro DIV_ROUND_CLOSEST performs the computation (x + d/2)/d
but is perhaps more readable.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/

)

// <smpl>
@haskernel@
@@

#include <linux/kernel.h>

@depends on haskernel@
expression x,__divisor;
@@

- (((x) + ((__divisor) / 2)) / (__divisor))
+ DIV_ROUND_CLOSEST(x,__divisor)
// </smpl>

Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 39506a55

drivers/atm/horizon.c

+2 −2
Original line number Diff line number Diff line
@@ -641,7 +641,7 @@ static int make_rate (const hrz_dev * dev, u32 c, rounding r, 
					pre = 1;

				break;

			case round_nearest:

				pre = (br+(c<<div)/2)/(c<<div);

				pre = DIV_ROUND_CLOSEST(br, c<<div);

				// but p must be non-zero

				if (!pre)

					pre = 1;
@@ -671,7 +671,7 @@ static int make_rate (const hrz_dev * dev, u32 c, rounding r, 
					pre = DIV_ROUND_UP(br, c<<div);

					break;

				case round_nearest:

					pre = (br+(c<<div)/2)/(c<<div);

					pre = DIV_ROUND_CLOSEST(br, c<<div);

					break;

				default: /* round_up */

					pre = br/(c<<div);