Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8aef63ff authored by Ben Collins's avatar Ben Collins
Browse files

ieee1394: extend lowlevel API for address range properties 



Host adapter hardware imposes certain restrictions and features on
address ranges.  Instead of hard-wire such ranges into the ieee1394
core or even into protocol drivers, let lowlevel drivers specify
these ranges via struct hpsb_host.

Patch "ohci1394: set address range properties" must be applied too,
else hpsb_allocate_and_register_addrspace() won't work properly.

Signed-off-by: default avatarStefan Richter <stefanr@s5r6.in-berlin.de>
Signed-off-by: default avatarBen Collins <bcollins@ubuntu.com>
parent 20f45781

drivers/ieee1394/highlevel.c

+3 −1
Original line number Diff line number Diff line
@@ -312,8 +312,10 @@ u64 hpsb_allocate_and_register_addrspace(struct hpsb_highlevel *hl, 
		return retval;

	}



	/* default range,

	 * avoids controller's posted write area (see OHCI 1.1 clause 1.5) */

	if (start == ~0ULL && end == ~0ULL) {

		start = CSR1212_ALL_SPACE_BASE + 0xffff00000000ULL;  /* ohci1394.c limit */

		start = host->middle_addr_space;

		end = CSR1212_ALL_SPACE_END;

	}

drivers/ieee1394/hosts.h

+2 −0
Original line number Diff line number Diff line
@@ -73,6 +73,8 @@ struct hpsb_host { 
	unsigned int config_roms;



	struct list_head addr_space;

	u64 low_addr_space;	/* upper bound of physical DMA area */

	u64 middle_addr_space;	/* upper bound of posted write area */

};