Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8ad08d8a authored by Al Viro's avatar Al Viro
Browse files

may_umount() needs namespace_sem 



otherwise it races with clone_mnt() changing mnt_share/mnt_slaves

Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent 9b6e3102

fs/namespace.c

+2 −0
Original line number Original line Diff line number Diff line
@@ -965,10 +965,12 @@ EXPORT_SYMBOL(may_umount_tree); 
int may_umount(struct vfsmount *mnt)

int may_umount(struct vfsmount *mnt)

{

{

	int ret = 1;

	int ret = 1;

	down_read(&namespace_sem);

	spin_lock(&vfsmount_lock);

	spin_lock(&vfsmount_lock);

	if (propagate_mount_busy(mnt, 2))

	if (propagate_mount_busy(mnt, 2))

		ret = 0;

		ret = 0;

	spin_unlock(&vfsmount_lock);

	spin_unlock(&vfsmount_lock);

	up_read(&namespace_sem);

	return ret;

	return ret;

}

}