Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8abbbaf6 authored by Daniel Vetter's avatar Daniel Vetter
Browse files

drm: don't unlock in the addfb error paths 



We don't grab the modeset locks any more since

commit 468174f7
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date:   Tue Dec 11 00:09:12 2012 +0100

    drm: push modeset_lock_all into ->fb_create driver callbacks

Reported-by: default avatarRay Strode <rstrode@redhat.com>
Cc: Ray Strode <rstrode@redhat.com>
Cc: Dave Airlie <airlied@gmail.com>
Acked-by: default avatarDave Airlie <airlied@gmail.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent 27b7c63a

drivers/gpu/drm/drm_crtc.c

+0 −2
Original line number Diff line number Diff line
@@ -2326,7 +2326,6 @@ int drm_mode_addfb(struct drm_device *dev, 
	fb = dev->mode_config.funcs->fb_create(dev, file_priv, &r);

	if (IS_ERR(fb)) {

		DRM_DEBUG_KMS("could not create framebuffer\n");

		drm_modeset_unlock_all(dev);

		return PTR_ERR(fb);

	}
@@ -2506,7 +2505,6 @@ int drm_mode_addfb2(struct drm_device *dev, 
	fb = dev->mode_config.funcs->fb_create(dev, file_priv, r);

	if (IS_ERR(fb)) {

		DRM_DEBUG_KMS("could not create framebuffer\n");

		drm_modeset_unlock_all(dev);

		return PTR_ERR(fb);

	}