Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8a6201b9 authored by Tony Lindgren's avatar Tony Lindgren
Browse files

ARM: OMAP2+: Fix unmet direct dependencies for zoom for 8250 serial 



We should not select drivers from kconfig as they should by default
be optional. Otherwise we'll be chasing broken dependencies forever:

warning: (MACH_OMAP_ZOOM2 && MACH_OMAP_ZOOM3 && MWAVE) selects SERIAL_8250
which has unmet direct dependencies (TTY && HAS_IOMEM && GENERIC_HARDIRQS)

Fix the issue by removing the selects for zoom and add them to
omap2plus_defconfig.

Reported-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
parent 990fa4f5

arch/arm/configs/omap2plus_defconfig

+2 −0
Original line number Original line Diff line number Diff line
@@ -126,6 +126,8 @@ CONFIG_INPUT_MISC=y 
CONFIG_INPUT_TWL4030_PWRBUTTON=y

CONFIG_INPUT_TWL4030_PWRBUTTON=y

CONFIG_VT_HW_CONSOLE_BINDING=y

CONFIG_VT_HW_CONSOLE_BINDING=y

# CONFIG_LEGACY_PTYS is not set

# CONFIG_LEGACY_PTYS is not set

CONFIG_SERIAL_8250=y

CONFIG_SERIAL_8250_CONSOLE=y

CONFIG_SERIAL_8250_NR_UARTS=32

CONFIG_SERIAL_8250_NR_UARTS=32

CONFIG_SERIAL_8250_EXTENDED=y

CONFIG_SERIAL_8250_EXTENDED=y

CONFIG_SERIAL_8250_MANY_PORTS=y

CONFIG_SERIAL_8250_MANY_PORTS=y

arch/arm/mach-omap2/Kconfig

+0 −6
Original line number Original line Diff line number Diff line
@@ -311,9 +311,6 @@ config MACH_OMAP_ZOOM2 
	default y

	default y

	select OMAP_PACKAGE_CBB

	select OMAP_PACKAGE_CBB

	select REGULATOR_FIXED_VOLTAGE if REGULATOR

	select REGULATOR_FIXED_VOLTAGE if REGULATOR

	select SERIAL_8250

	select SERIAL_8250_CONSOLE

	select SERIAL_CORE_CONSOLE





config MACH_OMAP_ZOOM3

config MACH_OMAP_ZOOM3

	bool "OMAP3630 Zoom3 board"

	bool "OMAP3630 Zoom3 board"
@@ -321,9 +318,6 @@ config MACH_OMAP_ZOOM3 
	default y

	default y

	select OMAP_PACKAGE_CBP

	select OMAP_PACKAGE_CBP

	select REGULATOR_FIXED_VOLTAGE if REGULATOR

	select REGULATOR_FIXED_VOLTAGE if REGULATOR

	select SERIAL_8250

	select SERIAL_8250_CONSOLE

	select SERIAL_CORE_CONSOLE





config MACH_CM_T35

config MACH_CM_T35

	bool "CompuLab CM-T35/CM-T3730 modules"

	bool "CompuLab CM-T35/CM-T3730 modules"