Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8a52da63 authored by Julia Lawall's avatar Julia Lawall Committed by James Bottomley
Browse files

[SCSI] aacraid: Eliminate use after free 

The debugging code using the freed structure is moved before the kfree.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/

)

// <smpl>
@free@
expression E;
position p;
@@
kfree@p(E)

@@
expression free.E, subE<=free.E, E1;
position free.p;
@@

  kfree@p(E)
  ...
(
  subE = E1
|
* E
)
// </smpl>

Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@suse.de>
parent 36b83ded

drivers/scsi/aacraid/commctrl.c

+2 −2
Original line number Diff line number Diff line
@@ -655,9 +655,9 @@ static int aac_send_raw_srb(struct aac_dev* dev, void __user * arg) 
				/* Does this really need to be GFP_DMA? */

				p = kmalloc(usg->sg[i].count,GFP_KERNEL|__GFP_DMA);

				if(!p) {

					kfree (usg);

					dprintk((KERN_DEBUG "aacraid: Could not allocate SG buffer - size = %d buffer number %d of %d\n",

					  usg->sg[i].count,i,usg->count));

					kfree(usg);

					rcode = -ENOMEM;

					goto cleanup;

				}