Commit 8a20d84d authored Mar 09, 2009 by Ingo Molnar

tracing: trace_printk() fix, move format array to data section



Impact: fix kernel crash when using trace_printk()

trace_printk_fmt section is defined into the readonly section.
But we do:

	trace_printk_fmt = fmt;

to fill in that table of format strings - which is not read-only.
Under CONFIG_DEBUG_RODATA=y this crashes ...

Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Peter Zijlstra <peterz@infradead.org>
LKML-Reference: <1236356510-8381-5-git-send-email-fweisbec@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

parent 9de36825

include/asm-generic/vmlinux.lds.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -98,6 +98,7 @@
		VMLINUX_SYMBOL(__stop___tracepoints) = .; \
		LIKELY_PROFILE() \
		BRANCH_PROFILE() \
		TRACE_PRINTKS() \
		FTRACE_EVENTS()

		#define RO_DATA(align) \
		@@ -108,7 +109,6 @@
		(__vermagic) / Kernel version magic */ \
		(__markers_strings) / Markers: strings */ \
		(__tracepoints_strings)/ Tracepoints: strings */ \
		TRACE_PRINTKS() \
		} \
		\
		.rodata1 : AT(ADDR(.rodata1) - LOAD_OFFSET) { \